[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on sparc
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on sparc |
Date: |
Tue, 02 Feb 2016 21:04:38 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake <address@hidden> writes:
> Commit 86f4b687 broke compilation on sparc, which has a preprocessor
> pollution of '#define sparc 1'. Treat it the same way as we do for
> the pollution with 'unix', so that QMP remains backwards compatible
> and only the C code needs to use the alternative 'q_sparc' spelling.
>
> CC: Peter Maydell <address@hidden>
> Signed-off-by: Eric Blake <address@hidden>
> ---
>
> Done as a followup to the same style of patch for MIPS; or we could
> squash this into one patch.
Applied to qapi-next squashed:
qapi: Fix compilation failure on MIPS and SPARC
Commit 86f4b687 broke compilation on MIPS and SPARC, which have a
preprocessor pollution of '#define mips 1' and '#define space 1',
respectively. Treat it the same way as we do for the pollution with
'unix', so that QMP remains backwards compatible and only the C code
needs to use the alternative 'q_mips' spelling.
CC: James Hogan <address@hidden>
CC: Peter Maydell <address@hidden>
Signed-off-by: Eric Blake <address@hidden>
Tested-by: James Hogan <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>