[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] m68k: Build the opcode table only once to avoid
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] m68k: Build the opcode table only once to avoid multithreading issues |
Date: |
Wed, 3 Feb 2016 08:16:52 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 02/03/2016 03:14 AM, John Paul Adrian Glaubitz wrote:
> Signed-off-by: John Paul Adrian Glaubitz <address@hidden>
> ---
> target-m68k/translate.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index 535d7f9..a989961 100644
> --- a/target-m68k/translate.c
> +++ b/target-m68k/translate.c
> @@ -2828,6 +2828,10 @@ register_opcode (disas_proc proc, uint16_t opcode,
> uint16_t mask)
> Later insn override earlier ones. */
> void register_m68k_insns (CPUM68KState *env)
> {
> + /* Build the opcode table only once to avoid
> + multithreading issues. */
> + if (opcode_table[0] != NULL)
> + return;
Missing {}. Are you sure this is the version that passed checkpatch.pl?
> #define INSN(name, opcode, mask, feature) do { \
> if (m68k_feature(env, M68K_FEATURE_##feature)) \
> register_opcode(disas_##name, 0x##opcode, 0x##mask); \
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] Updated patch for the opcode table, John Paul Adrian Glaubitz, 2016/02/03
- [Qemu-devel] [PATCH] m68k: Build the opcode table only once to avoid multithreading issues, John Paul Adrian Glaubitz, 2016/02/03
- Re: [Qemu-devel] [PATCH] m68k: Build the opcode table only once to avoid multithreading issues,
Eric Blake <=
- Re: [Qemu-devel] [PATCH] m68k: Build the opcode table only once to avoid multithreading issues, Laurent Vivier, 2016/02/03
- Re: [Qemu-devel] [PATCH] m68k: Build the opcode table only once to avoid multithreading issues, John Paul Adrian Glaubitz, 2016/02/03
- Re: [Qemu-devel] [PATCH] m68k: Build the opcode table only once to avoid multithreading issues, Eric Blake, 2016/02/03
- Re: [Qemu-devel] [PATCH] m68k: Build the opcode table only once to avoid multithreading issues, John Paul Adrian Glaubitz, 2016/02/04
- Re: [Qemu-devel] [PATCH] m68k: Build the opcode table only once to avoid multithreading issues, John Paul Adrian Glaubitz, 2016/02/08