[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 26/28] ipmi: do not take/drop iothread lock
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 26/28] ipmi: do not take/drop iothread lock |
Date: |
Mon, 8 Feb 2016 18:03:17 +0100 |
This is not necessary and actually causes a hang; it was probably copied
and pasted from KVM code, that is one of the very few places that run
outside iothread lock.
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/ipmi/ipmi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/ipmi/ipmi.c b/hw/ipmi/ipmi.c
index dfab272..6adec1e 100644
--- a/hw/ipmi/ipmi.c
+++ b/hw/ipmi/ipmi.c
@@ -51,9 +51,7 @@ static int ipmi_do_hw_op(IPMIInterface *s, enum ipmi_op op,
int checkonly)
if (checkonly) {
return 0;
}
- qemu_mutex_lock_iothread();
qmp_inject_nmi(NULL);
- qemu_mutex_unlock_iothread();
return 0;
case IPMI_POWERCYCLE_CHASSIS:
--
1.8.3.1
- [Qemu-devel] [PULL 11/28] qemu-nbd: Fix texi sentence capitalisation, (continued)
- [Qemu-devel] [PULL 11/28] qemu-nbd: Fix texi sentence capitalisation, Paolo Bonzini, 2016/02/08
- [Qemu-devel] [PULL 13/28] nbd: avoid unaligned uint64_t store, Paolo Bonzini, 2016/02/08
- [Qemu-devel] [PULL 16/28] target-i386: Create gen_lea_v_seg, Paolo Bonzini, 2016/02/08
- [Qemu-devel] [PULL 08/28] hw: Add support for LSI SAS1068 (mptsas) device, Paolo Bonzini, 2016/02/08
- [Qemu-devel] [PULL 20/28] target-i386: Access segs via TCG registers, Paolo Bonzini, 2016/02/08
- [Qemu-devel] [PULL 22/28] target-i386: Rewrite gen_enter inline, Paolo Bonzini, 2016/02/08
- [Qemu-devel] [PULL 21/28] target-i386: Use gen_lea_v_seg in pusha/popa, Paolo Bonzini, 2016/02/08
- [Qemu-devel] [PULL 27/28] ipmi_bmc_sim: Fix off by one in check., Paolo Bonzini, 2016/02/08
- [Qemu-devel] [PULL 24/28] target-i386: Tidy gen_add_A0_im, Paolo Bonzini, 2016/02/08
- [Qemu-devel] [PULL 23/28] target-i386: Rewrite leave, Paolo Bonzini, 2016/02/08
- [Qemu-devel] [PULL 26/28] ipmi: do not take/drop iothread lock,
Paolo Bonzini <=
- [Qemu-devel] [PULL 28/28] ipmi_bmc_sim: Add break to correct watchdog NMI check, Paolo Bonzini, 2016/02/08
- [Qemu-devel] [PULL 25/28] target-i386: Deconstruct the cpu_T array, Paolo Bonzini, 2016/02/08
- Re: [Qemu-devel] [PULL 00/28] Misc changes for 2016-02-08, Peter Maydell, 2016/02/09