[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv7 3/9] slirp: Adding IPv6 UDP support
From: |
Samuel Thibault |
Subject: |
Re: [Qemu-devel] [PATCHv7 3/9] slirp: Adding IPv6 UDP support |
Date: |
Tue, 9 Feb 2016 22:13:59 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Thomas Huth, on Tue 09 Feb 2016 21:44:18 +0100, wrote:
> > + case AF_INET6:
> > + udp6_output(so, m, (struct sockaddr_in6 *) &saddr,
> > + (struct sockaddr_in6 *) &daddr);
> > + break;
> > default:
> > + g_assert_not_reached();
>
> Could this be triggered by the guest?
No, here we are in sorecvfrom, which only reads ipv4 or ipv6 packets
from the udp socket.
> > + so->so_ffamily = AF_INET6;
> > + so->so_faddr6 = ip->ip_dst; /* XXX */
> > + so->so_fport6 = uh->uh_dport; /* XXX */
>
> Why use the XXXs here? Some additional words in the comments would be
> nice...
That's a copy/paste from the UDPv4 code. I don't know why they are there.
Samuel
- [Qemu-devel] [PATCHv7 6/9] slirp: Reindent after refactoring, (continued)
- [Qemu-devel] [PATCHv7 6/9] slirp: Reindent after refactoring, Samuel Thibault, 2016/02/08
- [Qemu-devel] [PATCHv7 4/9] slirp: Factorizing tcpiphdr structure with an union, Samuel Thibault, 2016/02/08
- [Qemu-devel] [PATCHv7 8/9] slirp: Adding IPv6 address for DNS relay, Samuel Thibault, 2016/02/08
- [Qemu-devel] [PATCHv7 7/9] slirp: Handle IPv6 in TCP functions, Samuel Thibault, 2016/02/08
- [Qemu-devel] [PATCHv7 5/9] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff, Samuel Thibault, 2016/02/08
- [Qemu-devel] [PATCHv7 9/9] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses, Samuel Thibault, 2016/02/08
- [Qemu-devel] [PATCHv7 3/9] slirp: Adding IPv6 UDP support, Samuel Thibault, 2016/02/08
[Qemu-devel] [PATCHv7 1/9] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration, Samuel Thibault, 2016/02/08
Re: [Qemu-devel] [PATCHv7 1/9] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration, Eric Blake, 2016/02/09
Re: [Qemu-devel] [PATCHv7 1/9] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration, Samuel Thibault, 2016/02/09