Re: [Qemu-devel] [PATCH 2/3] qdev-monitor: add missing aliases for virtio-{9p, balloon, rng, scsi}

[Sascha Silbe]

Dear Conny,

Cornelia Huck <address@hidden> writes:

> On Thu, 11 Feb 2016 10:01:35 +0100
> Markus Armbruster <address@hidden> wrote:
>
>> Sascha Silbe <address@hidden> writes:
>
>> > This leaves out
>> > virtio-{gpu,input,input-hid,input-host,keyboard,mouse,tablet} because
>> > they're currently only implemented using PCI, so there's no immediate
>> > value in having them. It would nevertheless make sense to include them
>> > so they can get used already and will start to Just Work™ on s390x
>> > once a CCW implementation appears. I can post the corresponding patch
>> > if there's any interest.
>> 
>> I guess that's for the virtio people to decide.  I'm cc'ing some.
>
> What would the error look like if one decided to use e.g. virtio-gpu on
> s390x? If the error is more specific (i.e. virtio-gpu-ccw does not
> exist vs. virtio-gpu does not exist), I think adding the aliases makes
> sense: the user sees what is actually missing.

Interesting point. Indeed, if we already define the matching -ccw
aliases, the error message may be slightly more useful:

address@hidden:~/recoverable/qemu$ s390x-softmmu/qemu-system-s390x -device 
virtio-gpu
qemu-system-s390x: -device virtio-gpu: 'virtio-gpu-ccw' is not a valid device 
model name

Though we should probably at least add a comment to the alias list
mentioning that this is intentional. We might even want to adjust
qdev_get_device_class() to print a more specific error message in this
case.

Sascha
-- 
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641