[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v1 7/9] target-arm: Add the ARMInsnSyndrome type
From: |
Edgar E. Iglesias |
Subject: |
[Qemu-devel] [PATCH v1 7/9] target-arm: Add the ARMInsnSyndrome type |
Date: |
Fri, 12 Feb 2016 15:34:00 +0100 |
From: "Edgar E. Iglesias" <address@hidden>
Add the ARMInsnSyndrome type including helper functions to
encode and decode it into an u32. This is in preparation for
Instruction Syndrome generation for Data Aborts.
No functional change.
Signed-off-by: Edgar E. Iglesias <address@hidden>
---
target-arm/cpu.h | 22 +++++++++++++++++++
target-arm/translate.h | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 79 insertions(+)
diff --git a/target-arm/cpu.h b/target-arm/cpu.h
index 5137632..a00a121 100644
--- a/target-arm/cpu.h
+++ b/target-arm/cpu.h
@@ -123,6 +123,28 @@ typedef struct {
uint32_t base_mask;
} TCR;
+/* Holds the state needed to create an instruction syndrome. */
+typedef struct ARMInsnSyndrome {
+ /* Data Abort section. */
+ struct {
+ bool valid;
+ unsigned int sas;
+ bool sse;
+ unsigned int srt;
+ bool sf;
+ bool ar;
+ } dabt;
+
+ /* SWStep section. */
+ struct {
+ /* True if the insn just emitted was a load-exclusive instruction
+ * (necessary for syndrome information for single step exceptions),
+ * ie A64 LDX*, LDAX*, A32/T32 LDREX*, LDAEX*.
+ */
+ bool ex;
+ } swstep;
+} ARMInsnSyndrome;
+
typedef struct CPUARMState {
/* Regs for current mode. */
uint32_t regs[16];
diff --git a/target-arm/translate.h b/target-arm/translate.h
index 53ef971..a94e17e 100644
--- a/target-arm/translate.h
+++ b/target-arm/translate.h
@@ -151,4 +151,61 @@ void arm_free_cc(DisasCompare *cmp);
void arm_jump_cc(DisasCompare *cmp, TCGLabel *label);
void arm_gen_test_cc(int cc, TCGLabel *label);
+
+/* The following describes the packing and unpacking of the Data Abort
+ * section of an ARMInsnSyndrome from/into an u32.
+ */
+
+/* Field widths. */
+#define ISYN_WIDTH_valid 1
+#define ISYN_WIDTH_sas 2
+#define ISYN_WIDTH_sse 1
+#define ISYN_WIDTH_srt 5
+#define ISYN_WIDTH_sf 1
+#define ISYN_WIDTH_ar 1
+
+/* We use 64bit deposit to allow for overflow checking. */
+#define ISYN_SHIFT_IN(val, isyn, field) \
+ { \
+ unsigned int width = xglue(ISYN_WIDTH_, field); \
+ val <<= width; \
+ val = deposit64(val, 0, width, (isyn).field); \
+ } while (0)
+
+#define ISYN_SHIFT_OUT(val, isyn, field) \
+ { \
+ unsigned int width = xglue(ISYN_WIDTH_, field); \
+ (isyn).field = extract32(val, 0, width); \
+ val >>= width; \
+ } while (0)
+
+static inline uint32_t arm_encode_dabt_isyn_u32(ARMInsnSyndrome *isyn)
+{
+ uint64_t v = 0;
+ uint32_t v32;
+
+ ISYN_SHIFT_IN(v, isyn->dabt, valid);
+ ISYN_SHIFT_IN(v, isyn->dabt, sas);
+ ISYN_SHIFT_IN(v, isyn->dabt, sse);
+ ISYN_SHIFT_IN(v, isyn->dabt, srt);
+ ISYN_SHIFT_IN(v, isyn->dabt, sf);
+ ISYN_SHIFT_IN(v, isyn->dabt, ar);
+ /* Check for overflows. */
+ v32 = v;
+ assert(v32 == v);
+ return v32;
+}
+
+static inline void arm_decode_dabt_isyn_u32(ARMInsnSyndrome *isyn, uint32_t v)
+{
+ /* The fields must be shifted out in reverse order. */
+ ISYN_SHIFT_OUT(v, isyn->dabt, ar);
+ ISYN_SHIFT_OUT(v, isyn->dabt, sf);
+ ISYN_SHIFT_OUT(v, isyn->dabt, srt);
+ ISYN_SHIFT_OUT(v, isyn->dabt, sse);
+ ISYN_SHIFT_OUT(v, isyn->dabt, sas);
+ ISYN_SHIFT_OUT(v, isyn->dabt, valid);
+ assert(v == 0);
+}
+
#endif /* TARGET_ARM_TRANSLATE_H */
--
1.9.1
- [Qemu-devel] [PATCH v1 1/9] tcg: Add tcg_set_insn_param, (continued)
- [Qemu-devel] [PATCH v1 1/9] tcg: Add tcg_set_insn_param, Edgar E. Iglesias, 2016/02/12
- [Qemu-devel] [PATCH v1 2/9] gen-icount: Use tcg_set_insn_param, Edgar E. Iglesias, 2016/02/12
- [Qemu-devel] [PATCH v1 3/9] target-arm: Add the thumb/IL flag to syn_data_abort, Edgar E. Iglesias, 2016/02/12
- [Qemu-devel] [PATCH v1 4/9] target-arm: Add more fields to the data abort syndrome generator, Edgar E. Iglesias, 2016/02/12
- [Qemu-devel] [PATCH v1 5/9] target-arm/translate-a64.c: Use extract32 in disas_ldst_reg_imm9, Edgar E. Iglesias, 2016/02/12
- [Qemu-devel] [PATCH v1 6/9] target-arm/translate-a64.c: Unify some of the ldst_reg decoding, Edgar E. Iglesias, 2016/02/12
- [Qemu-devel] [PATCH v1 7/9] target-arm: Add the ARMInsnSyndrome type,
Edgar E. Iglesias <=
- [Qemu-devel] [PATCH v1 8/9] target-arm: A64: Create Instruction Syndromes for Data Aborts, Edgar E. Iglesias, 2016/02/12
[Qemu-devel] [PATCH v1 9/9] target-arm: Use isyn.swstep.ex to hold the is_ldex state, Edgar E. Iglesias, 2016/02/12