Re: [Qemu-devel] [PATCH RFC] qmp, target-i386: device_list_properties for TYPE_CPU

[Eduardo Habkost]

On Fri, Feb 12, 2016 at 12:30:34PM +0100, Andreas Färber wrote:
> Hi,
> 
> Am 12.02.2016 um 10:13 schrieb Valentin Rakush:
> > This is RFC because there is another implementation option: it is
> > possible to implement this functionality in the object_finalize for
> > all available targets. All targets change will require more testing.
> > Please let me know if all targets should be changed at once.
> 
> I thought I had already seen some Fujitsu/IBM patch to fix this...
> (pointers appreciated) It should be fixed on the level where the problem
> is introduced - i.e. if qom/cpu.c calls the cpu_exec_init() in
> instance_init it needs to call the corresponding exit function in
> instance_finalize; dito for target-i386/cpu.c or wherever. Or we try to
> move it from instance_init to realize, avoiding it getting called in the
> first place.

cpu_exec_init() calls must all be moved to realize.

-- 
Eduardo