Re: [Qemu-devel] [PATCH v2 03/11] acpi: add aml_create_field()

[Xiao Guangrong]

On 02/08/2016 06:47 PM, Igor Mammedov wrote:
> On Wed, 13 Jan 2016 02:50:02 +0800
> Xiao Guangrong <address@hidden> wrote:
>
> > It will be used by nvdimm acpi
> >
> > Signed-off-by: Xiao Guangrong <address@hidden>
> > ---
> >   hw/acpi/aml-build.c         | 13 +++++++++++++
> >   include/hw/acpi/aml-build.h |  1 +
> >   2 files changed, 14 insertions(+)
> >
> > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> > index 78e1290..97c9efb 100644
> > --- a/hw/acpi/aml-build.c
> > +++ b/hw/acpi/aml-build.c
> > @@ -1001,6 +1001,19 @@ Aml *create_field_common(int opcode, Aml *srcbuf, Aml 
> > *index, const char *name)
> >       return var;
> >   }
> >
> > +/* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefCreateField */
> > +Aml *aml_create_field(Aml *srcbuf, Aml *index, Aml *len, const char *name)
> to match spec more closely pls do following:
> s/index/bit_index/
> s/len/num_bits/

Good to me, will do it in the next version.