[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC versi
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version |
Date: |
Mon, 15 Feb 2016 10:52:01 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Peter Xu <address@hidden> writes:
> For ARM platform, we still do not have any interface to query
> whether current QEMU/host support specific GIC version. This
> patchset is trying to add one QMP interface for that. By querying
> the GIC capability using the new interface, one should know exactly
> what GIC version(s) the platform will support. The capability bits
> will be decided by both QEMU and host kernel.
>
> The current patchset only provides interface for review. Its handler
> is a fake one which returns empty always.
>
> The command interface I am planning to add is something like this:
>
> -> { "execute": "query-gic-capability" }
> <- { "return": [ "gicv2", "gicv2-kvm", "gicv3-kvm" ] }
>
> Currently, all the possible supported GIC versions are:
>
> - gicv2: GIC version 2 without kernel IRQ chip
> - gicv2-kvm: GIC version 2 with kernel IRQ chip
> - gicv3: GIC version 3 without kernel IRQ chip (not supported)
> - gicv3-kvm: GIC version 3 with kernel IRQ chip
>
> Since "gicv3" is still not supported (to use GICv3, kernel irqchip
> support is required for now, which corresponds to "gicv3-kvm"),
> currently the maximum superset of the result should be:
>
> ["gicv2", "gicv2-kvm", "gicv3-kvm"]
>
> Please help review whether the interface suits our need, also please
> point out any error I have made.
Adding ad hoc queries as we go won't scale. Is there really no generic
way to get this information, e.g. with qom-get?
> One question: how should I make this command "ARM only"? I see that
> in qmp-commands.hx, I can use something like "#if defined
> TARGET_ARM" to block out ARM specified commands, however how should
> I do the similiar thing in qapi-schema.json?
Have a look at the #if in qmp-commands.hx.
- [Qemu-devel] [RFC PATCH 1/2] arm: gic: add GICType, (continued)
- [Qemu-devel] [RFC PATCH 1/2] arm: gic: add GICType, Peter Xu, 2016/02/14
- [Qemu-devel] [RFC PATCH 2/2] arm: gic: add "query-gic-capability" interface, Peter Xu, 2016/02/14
- Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version, Wei Huang, 2016/02/15
- Re: [Qemu-devel] [libvirt] [RFC PATCH 0/2] ARM: add QMP command to query GIC version, Martin Kletzander, 2016/02/15
- Re: [Qemu-devel] [libvirt] [RFC PATCH 0/2] ARM: add QMP command to query GIC version, Peter Xu, 2016/02/15
- Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version,
Markus Armbruster <=
- Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version, Peter Xu, 2016/02/15
- Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version, Markus Armbruster, 2016/02/15
- Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version, Peter Maydell, 2016/02/15
- Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version, Markus Armbruster, 2016/02/15
- Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version, Andrew Jones, 2016/02/15
- Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version, Peter Maydell, 2016/02/15
- Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version, Markus Armbruster, 2016/02/16
- Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version, Daniel P. Berrange, 2016/02/16
- Re: [Qemu-devel] [libvirt] [RFC PATCH 0/2] ARM: add QMP command to query GIC version, Andrea Bolognani, 2016/02/16
- Re: [Qemu-devel] [libvirt] [RFC PATCH 0/2] ARM: add QMP command to query GIC version, Peter Maydell, 2016/02/16