qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 09/11] Dump: add qmp command "query-dump"


From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH v6 09/11] Dump: add qmp command "query-dump"
Date: Tue, 16 Feb 2016 14:40:59 +0800
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, 12/09 10:42, Peter Xu wrote:
> -    s->status = (local_err ? DUMP_STATUS_FAILED : DUMP_STATUS_COMPLETED);
> -    error_propagate(errp, local_err);

This means the error is released by caller, ...

> +    /* make sure status is written after written_size updates */
> +    smp_wmb();
> +    atomic_set(&s->status,
> +               (local_err ? DUMP_STATUS_FAILED : DUMP_STATUS_COMPLETED));

but it is removed now.  Is local_err leaked now?

Fam



reply via email to

[Prev in Thread] Current Thread [Next in Thread]