[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v7 6/8] qemu-nbd: don't overlap long option values w
From: |
Daniel P. Berrange |
Subject: |
[Qemu-devel] [PATCH v7 6/8] qemu-nbd: don't overlap long option values with short options |
Date: |
Wed, 17 Feb 2016 10:10:21 +0000 |
When defining values for long options, the normal practice is
to start numbering from 256, to avoid overlap with the range
of valid values for short options.
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>
---
qemu-nbd.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index 424e71f..9ccfc13 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -37,13 +37,13 @@
#include <pthread.h>
#define SOCKET_PATH "/var/lock/qemu-nbd-%s"
-#define QEMU_NBD_OPT_CACHE 1
-#define QEMU_NBD_OPT_AIO 2
-#define QEMU_NBD_OPT_DISCARD 3
-#define QEMU_NBD_OPT_DETECT_ZEROES 4
-#define QEMU_NBD_OPT_OBJECT 5
-#define QEMU_NBD_OPT_TLSCREDS 6
-#define QEMU_NBD_OPT_IMAGE_OPTS 7
+#define QEMU_NBD_OPT_CACHE 256
+#define QEMU_NBD_OPT_AIO 257
+#define QEMU_NBD_OPT_DISCARD 258
+#define QEMU_NBD_OPT_DETECT_ZEROES 259
+#define QEMU_NBD_OPT_OBJECT 260
+#define QEMU_NBD_OPT_TLSCREDS 261
+#define QEMU_NBD_OPT_IMAGE_OPTS 262
static NBDExport *exp;
static bool newproto;
--
2.5.0
- [Qemu-devel] [PATCH v7 0/8] Make qemu-img/qemu-nbd/qemu-io CLI more flexible, Daniel P. Berrange, 2016/02/17
- [Qemu-devel] [PATCH v7 1/8] qemu-io: add support for --object command line arg, Daniel P. Berrange, 2016/02/17
- [Qemu-devel] [PATCH v7 3/8] qemu-io: allow specifying image as a set of options args, Daniel P. Berrange, 2016/02/17
- [Qemu-devel] [PATCH v7 2/8] qemu-img: add support for --object command line arg, Daniel P. Berrange, 2016/02/17
- [Qemu-devel] [PATCH v7 4/8] qemu-nbd: allow specifying image as a set of options args, Daniel P. Berrange, 2016/02/17
- [Qemu-devel] [PATCH v7 7/8] qemu-nbd: use no_argument/required_argument constants, Daniel P. Berrange, 2016/02/17
- [Qemu-devel] [PATCH v7 8/8] qemu-io: use no_argument/required_argument constants, Daniel P. Berrange, 2016/02/17
- [Qemu-devel] [PATCH v7 6/8] qemu-nbd: don't overlap long option values with short options,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH v7 5/8] qemu-img: allow specifying image as a set of options args, Daniel P. Berrange, 2016/02/17
- Re: [Qemu-devel] [PATCH v7 0/8] Make qemu-img/qemu-nbd/qemu-io CLI more flexible, Kevin Wolf, 2016/02/22