[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6] i2c-tiny-usb: a small usb to i2c bridge
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v6] i2c-tiny-usb: a small usb to i2c bridge |
Date: |
Wed, 17 Feb 2016 17:26:48 +0100 |
On Di, 2016-02-16 at 16:51 +0000, Alex Bennée wrote:
> Tim Sander <address@hidden> writes:
>
> > Oh my, so many stupid little errors. Due to firewall impairment i am
> > sending these
> > patches manually. Last time i forgot to disable the newline breaks which
> > made the
> > patch v5 unusable. Sorry for this inconvenience.
"git am" accepts this one, but ...
> Please run ${QEMU_SRC}/scripts/checkpatch.pl on your patch and correct
> the stylistic errors it reports.
... checkpatch.pl indeed throws a bunch of codestyle warnings.
> I'll echo Gerd's comments about the
> value of using git send-email to send patches. If you can glean you
> email clients SMTP settings then you should be able to get
> git-send-email to do this as well.
Yes, you can configure git send-email to use your internal mail server
to send out patches. Best place it in the global config
($HOME/.gitconfig instead of $repo/.git/config) so you don't have to
repeat the procedure for every git tree you have.
Alternatively you can configure a mail daemon such as postfix on your
workstation to deliver mails using your internal mail server as relay.
cheers,
Gerd