[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/13] vmxnet3: Use generic function for DSN cap
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 05/13] vmxnet3: Use generic function for DSN capability definition |
Date: |
Thu, 18 Feb 2016 12:46:45 +0200 |
On Thu, Feb 18, 2016 at 12:07:26PM +0200, Leonid Bloch wrote:
> From: Dmitry Fleytman <address@hidden>
>
> Signed-off-by: Dmitry Fleytman <address@hidden>
> Signed-off-by: Leonid Bloch <address@hidden>
> ---
> hw/net/vmxnet3.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
> index 093a71e..43f7a34 100644
> --- a/hw/net/vmxnet3.c
> +++ b/hw/net/vmxnet3.c
> @@ -2313,10 +2313,8 @@ static void vmxnet3_pci_realize(PCIDevice *pci_dev,
> Error **errp)
> pcie_endpoint_cap_init(pci_dev, VMXNET3_EXP_EP_OFFSET);
> }
>
> - pcie_add_capability(pci_dev, PCI_EXT_CAP_ID_DSN, 0x1,
> - VMXNET3_DSN_OFFSET, PCI_EXT_CAP_DSN_SIZEOF);
> - memcpy(pci_dev->config + VMXNET3_DSN_OFFSET + 4,
> - vmxnet3_device_serial_num(s), sizeof(uint64_t));
> + pcie_dsn_init(pci_dev, VMXNET3_DSN_OFFSET,
> + *(uint64_t *) vmxnet3_device_serial_num(s));
Can't we fix the API to avoid the cast?
> }
>
> register_savevm(dev, "vmxnet3-msix", -1, 1,
> --
> 2.5.0
- [Qemu-devel] [PATCH 00/13] Introduce Intel 82574 GbE Controller Emulation (e1000e), Leonid Bloch, 2016/02/18
- [Qemu-devel] [PATCH 02/13] pci: Introduce define for PM capability version 1.1, Leonid Bloch, 2016/02/18
- [Qemu-devel] [PATCH 01/13] msix: make msix_clr_pending() visible for clients, Leonid Bloch, 2016/02/18
- [Qemu-devel] [PATCH 03/13] pcie: Add support for PCIe CAP v1, Leonid Bloch, 2016/02/18
- [Qemu-devel] [PATCH 05/13] vmxnet3: Use generic function for DSN capability definition, Leonid Bloch, 2016/02/18
- Re: [Qemu-devel] [PATCH 05/13] vmxnet3: Use generic function for DSN capability definition,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH 04/13] pcie: Introduce function for DSN capability creation, Leonid Bloch, 2016/02/18
- [Qemu-devel] [PATCH 06/13] net: Introduce Toeplitz hash calculator, Leonid Bloch, 2016/02/18
- [Qemu-devel] [PATCH 08/13] vmxnet3: Use common MAC address tracing macros, Leonid Bloch, 2016/02/18
- [Qemu-devel] [PATCH 07/13] net: Add macros for MAC address tracing, Leonid Bloch, 2016/02/18
- [Qemu-devel] [PATCH 10/13] rtl8139: Move more TCP definitions to common header, Leonid Bloch, 2016/02/18
- [Qemu-devel] [PATCH 09/13] net_pkt: Name vmxnet3 packet abstractions more generic, Leonid Bloch, 2016/02/18
- [Qemu-devel] [PATCH 11/13] net_pkt: Extend packet abstraction as required by e1000e functionality, Leonid Bloch, 2016/02/18