[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 05/15] qapi-visit: Simplify how we visit com
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v11 05/15] qapi-visit: Simplify how we visit common union members |
Date: |
Thu, 18 Feb 2016 07:40:45 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 02/18/2016 05:16 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
>> From: Markus Armbruster <address@hidden>
>>
>> For a simple union SU, gen_visit_union() generates a visit of its
>> single tag member, like this:
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Message-Id: <address@hidden>
>> [rebase, improve commit message example]
>> Signed-off-by: Eric Blake <address@hidden>
>
> v10 had a noteworthy rebase, but v11 is the original patch again, with
> only the line numbers shifted a bit. Suggest to drop "rebase, ".
Concur.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v11 00/15] prune some QAPI visitor cruft (was qapi cleanups subset E), Eric Blake, 2016/02/18
- [Qemu-devel] [PATCH v11 01/15] qapi: Simplify excess input reporting in input visitors, Eric Blake, 2016/02/18
- [Qemu-devel] [PATCH v11 04/15] qapi: Add tests of complex objects within alternate, Eric Blake, 2016/02/18
- [Qemu-devel] [PATCH v11 05/15] qapi-visit: Simplify how we visit common union members, Eric Blake, 2016/02/18
- [Qemu-devel] [PATCH v11 02/15] qapi: Forbid empty unions and useless alternates, Eric Blake, 2016/02/18
- [Qemu-devel] [PATCH v11 07/15] qapi-visit: Unify struct and union visit, Eric Blake, 2016/02/18
- [Qemu-devel] [PATCH v11 15/15] qapi: Change visit_start_implicit_struct to visit_start_alternate, Eric Blake, 2016/02/18
- [Qemu-devel] [PATCH v11 03/15] qapi: Forbid 'any' inside an alternate, Eric Blake, 2016/02/18