[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 12/15] qapi: Don't box struct branch of alte
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v11 12/15] qapi: Don't box struct branch of alternate |
Date: |
Thu, 18 Feb 2016 13:00:49 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 02/18/2016 11:56 AM, Markus Armbruster wrote:
> Better, but the sentence is long enough to confuse even a German. What
> about:
lol
>
> The corresponding spot in qapi-visit.c calls visit_type_FOO(), which
> first calls visit_start_struct() to allocate or deallocate the member
> and handle a layer of {} from the JSON stream, then visits the
> members. To peel off the indirection and the memory management that
> comes with it, we inline this call, then suppress allocation /
> deallocation by passing NULL to visit_start_struct(), and adjust the
> member visit:
Works for me. [Technically, visit_start_struct() never deallocates, it
merely records a pointer for later deallocation during
visit_end_struct(); but I don't think we need to worry about the
imprecision here]
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v11 13/15] qapi: Don't box branches of flat unions, Eric Blake, 2016/02/18
Re: [Qemu-devel] [PATCH v11 00/15] prune some QAPI visitor cruft (was qapi cleanups subset E), Markus Armbruster, 2016/02/18
Re: [Qemu-devel] [PATCH v11 00/15] prune some QAPI visitor cruft (was qapi cleanups subset E), Markus Armbruster, 2016/02/18