[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 05/13] vfio/pci: replace 1 with PCI_CAP_LIST_NEXT to
From: |
Alex Williamson |
Subject: |
[Qemu-devel] [PULL 05/13] vfio/pci: replace 1 with PCI_CAP_LIST_NEXT to make code self-explain |
Date: |
Thu, 18 Feb 2016 13:06:15 -0700 |
User-agent: |
StGit/0.17.1-dirty |
From: Wei Yang <address@hidden>
Use the macro PCI_CAP_LIST_NEXT instead of 1, so that the code would be
more self-explain.
This patch makes this change and also fixs one typo in comment.
Signed-off-by: Wei Yang <address@hidden>
Signed-off-by: Alex Williamson <address@hidden>
---
hw/vfio/pci.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index e671506..dc5fa9f 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -1509,7 +1509,7 @@ static uint8_t vfio_std_cap_max_size(PCIDevice *pdev,
uint8_t pos)
uint16_t next = PCI_CONFIG_SPACE_SIZE;
for (tmp = pdev->config[PCI_CAPABILITY_LIST]; tmp;
- tmp = pdev->config[tmp + 1]) {
+ tmp = pdev->config[tmp + PCI_CAP_LIST_NEXT]) {
if (tmp > pos && tmp < next) {
next = tmp;
}
@@ -1698,7 +1698,7 @@ static int vfio_add_std_cap(VFIOPCIDevice *vdev, uint8_t
pos)
int ret;
cap_id = pdev->config[pos];
- next = pdev->config[pos + 1];
+ next = pdev->config[pos + PCI_CAP_LIST_NEXT];
/*
* If it becomes important to configure capabilities to their actual
@@ -1712,7 +1712,7 @@ static int vfio_add_std_cap(VFIOPCIDevice *vdev, uint8_t
pos)
* pci_add_capability always inserts the new capability at the head
* of the chain. Therefore to end up with a chain that matches the
* physical device, we insert from the end by making this recursive.
- * This is also why we pre-caclulate size above as cached config space
+ * This is also why we pre-calculate size above as cached config space
* will be changed as we unwind the stack.
*/
if (next) {
@@ -1728,7 +1728,7 @@ static int vfio_add_std_cap(VFIOPCIDevice *vdev, uint8_t
pos)
}
/* Use emulated next pointer to allow dropping caps */
- pci_set_byte(vdev->emulated_config_bits + pos + 1, 0xff);
+ pci_set_byte(vdev->emulated_config_bits + pos + PCI_CAP_LIST_NEXT, 0xff);
switch (cap_id) {
case PCI_CAP_ID_MSI:
- [Qemu-devel] [PULL 00/13] VFIO updates 2016-02-18, Alex Williamson, 2016/02/18
- [Qemu-devel] [PULL 01/13] pcie: modify the capability size assert, Alex Williamson, 2016/02/18
- [Qemu-devel] [PULL 02/13] vfio: make the 4 bytes aligned for capability size, Alex Williamson, 2016/02/18
- [Qemu-devel] [PULL 03/13] aer: impove pcie_aer_init to support vfio device, Alex Williamson, 2016/02/18
- [Qemu-devel] [PULL 04/13] pcie_aer: expose pcie_aer_msg() interface, Alex Williamson, 2016/02/18
- [Qemu-devel] [PULL 05/13] vfio/pci: replace 1 with PCI_CAP_LIST_NEXT to make code self-explain,
Alex Williamson <=
- [Qemu-devel] [PULL 06/13] hw/vfio/platform: amd-xgbe device, Alex Williamson, 2016/02/18
- [Qemu-devel] [PULL 07/13] device_tree: introduce load_device_tree_from_sysfs, Alex Williamson, 2016/02/18
- [Qemu-devel] [PULL 08/13] device_tree: introduce qemu_fdt_node_path, Alex Williamson, 2016/02/18
- [Qemu-devel] [PULL 09/13] device_tree: qemu_fdt_getprop converted to use the error API, Alex Williamson, 2016/02/18
- [Qemu-devel] [PULL 10/13] device_tree: qemu_fdt_getprop_cell converted to use the error API, Alex Williamson, 2016/02/18
- [Qemu-devel] [PULL 11/13] hw/arm/sysbus-fdt: helpers for clock node generation, Alex Williamson, 2016/02/18
- [Qemu-devel] [PULL 12/13] hw/arm/sysbus-fdt: enable amd-xgbe dynamic instantiation, Alex Williamson, 2016/02/18
- [Qemu-devel] [PULL 13/13] hw/arm/sysbus-fdt: remove qemu_fdt_setprop returned value check, Alex Williamson, 2016/02/18
- Re: [Qemu-devel] [PULL 00/13] VFIO updates 2016-02-18, Peter Maydell, 2016/02/19