Re: [Qemu-devel] [PATCH 01/17] chardev: Properly initialize ChardevCommon components

[Daniel P. Berrange]

On Fri, Feb 19, 2016 at 05:19:31PM -0700, Eric Blake wrote:
> Commit d0d7708b forgot to parse logging for spice chardevs and
> virtual consoles. This requires making qemu_chr_parse_common()
> non-static. While at it, use a temporary variable to make the
> code shorter, as well as reduce the churn when a later patch
> alters the layout of simple unions.
> 
> Signed-off-by: Eric Blake <address@hidden>
> CC: Daniel P. Berrange <address@hidden>
> ---
>  include/sysemu/char.h | 10 ++++++++++
>  qemu-char.c           |  2 +-
>  spice-qemu-char.c     | 12 ++++++++----
>  ui/console.c          | 20 +++++++++++---------
>  4 files changed, 30 insertions(+), 14 deletions(-)

Reviewed-by: Daniel P. Berrange <address@hidden>


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|