[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] qdev-monitor: improve error message when
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] qdev-monitor: improve error message when alias device is unavailable |
Date: |
Mon, 22 Feb 2016 12:54:29 +0100 |
On Thu, 18 Feb 2016 22:44:12 +0100
Sascha Silbe <address@hidden> wrote:
> When trying to instantiate an alias that points to a device class that
> doesn't exist, the error message looks like qemu misunderstood the
> request:
>
> $ s390x-softmmu/qemu-system-s390x -device virtio-gpu
> qemu-system-s390x: -device virtio-gpu: 'virtio-gpu-ccw' is not a valid
> device model name
>
> Special-case the error message to make it explicit that alias
> expansion is going on:
>
> $ s390x-softmmu/qemu-system-s390x -device virtio-gpu
> qemu-system-s390x: -device virtio-gpu: 'virtio-gpu' (alias
> 'virtio-gpu-ccw') is not a valid device model name
>
> Suggested-By: Cornelia Huck <address@hidden>
> Signed-off-by: Sascha Silbe <address@hidden>
> ---
> v1->v2: new patch
> ---
> qdev-monitor.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
Reviewed-by: Cornelia Huck <address@hidden>