[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] scripts/kvm/kvm_stat: Fix missing right para
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2] scripts/kvm/kvm_stat: Fix missing right parantheses and ".format(...)" |
Date: |
Mon, 22 Feb 2016 17:29:51 +0000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Feb 19, 2016 at 10:20:16AM +0800, Fam Zheng wrote:
> They seem to have snuck in when applying Janosch Frank
> <address@hidden>'s previous patch.
>
> Signed-off-by: Fam Zheng <address@hidden>
>
> ---
> v2: Also fix .format. [Janosch]
> ---
> scripts/kvm/kvm_stat | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
> index 3cf1181..769d884 100755
> --- a/scripts/kvm/kvm_stat
> +++ b/scripts/kvm/kvm_stat
> @@ -796,11 +796,12 @@ def check_access(options):
> sys.stderr.write("Please enable CONFIG_TRACING in your kernel "
> "when using the option -t (default).\n"
> "If it is enabled, make {0} readable by the "
> - "current user.\n")
> + "current user.\n"
> + .format(PATH_DEBUGFS_TRACING))
According to ./configure the minimum Python version is 2.4.
str.format() is a Python 2.6+ feature.
Is ./configure wrong (i.e. you are sure that the current crop of stable
Debian, Red Hat, and SLES distros have 2.6+)? If so, please fix
./configure.
Otherwise please use traditional Python string formatting instead.
Stefan
signature.asc
Description: PGP signature