Re: [Qemu-devel] [PATCH] topology.h: cleanup

[Cao jin]

On 02/24/2016 05:16 AM, Eduardo Habkost wrote:
> On Tue, Feb 23, 2016 at 02:51:11PM +0800, Cao jin wrote:
> > remove useless parameter of several functions
> >
> > Signed-off-by: Cao jin <address@hidden>
>
> I believe this makes the API much easier to be misused. Currently
> you can safely use (smp_cores, smp_threads) every time. With this
> patch, you need to always check the function definition to find
> out what's the correct argument.

Yes, you do have a point here, and very interesting to me. A caller need 
to know/check how to use a api if it want to use it, seems a nature 
thing to me.

Thanks for your explanation.

--
Yours Sincerely,

Cao jin