[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list()
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list() |
Date: |
Thu, 25 Feb 2016 12:12:12 +0200 |
On Thu, Feb 25, 2016 at 11:09:16AM +0100, Paolo Bonzini wrote:
>
>
> On 25/02/2016 10:54, Vladimir Sementsov-Ogievskiy wrote:
> > On 25.02.2016 12:11, Michael S. Tsirkin wrote:
> >> On Thu, Feb 25, 2016 at 11:55:56AM +0300, Vladimir Sementsov-Ogievskiy
> >> wrote:
> >>> On 25.02.2016 11:39, Michael S. Tsirkin wrote:
> >>>> On Thu, Feb 25, 2016 at 10:01:18AM +0300, Vladimir
> >>>> Sementsov-Ogievskiy wrote:
> >>>>> Stop!
> >>>> It builds fine here. Did you check out my tree?
> >>> anyway, this file should be here, as it is added into Makefile:
> >>>
> >>> --- a/stubs/Makefile.objs
> >>> +++ b/stubs/Makefile.objs
> >>> @@ -35,7 +35,7 @@ stub-obj-y += vmstate.o
> >>> stub-obj-$(CONFIG_WIN32) += fd-register.o
> >>> stub-obj-y += cpus.o
> >>> stub-obj-y += kvm.o
> >>> -stub-obj-y += qmp_pc_dimm_device_list.o
> >>> +stub-obj-y += pc_dimm.o
> >>> stub-obj-y += target-monitor-defs.o
> >>> stub-obj-y += target-get-monitor-def.o
> >>> stub-obj-y += vhost.o
> >>>
> >> Hmm that's right.
> >> Thanks!
> >> Looks like it was picking up an old object in the filesystem :(
> >> I'll respin - for now, does everything work for you if you drop
> >> this line from the makefile?
> >
> > it will break compilation for targets without memory hotplug, it was
> > discussed on list. stubs are necessary.
>
> mst,
>
> indeed it's not clear to me why you're deleting qmp_pc_dimm_device_list.c...
>
> On the other hand, pc_dimm_build_list doesn't need a stub. Just put it
> in hw/virtio/virtio-balloon.c.
>
> Paolo
Bad merge and I corrupted my test system again so it was
missing the problem :(
I'm fixing it up, thanks everyone!
> >
> >>
> >>> ===========
> >>> git clone git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tmp
> >>> cd tmp/
> >>> git checkout for_upstream
> >>> ./configure --target-list=x86_64-softmmu
> >>> make -j9
> >>>> make: *** No rule to make target `stubs/pc_dimm.o', needed by
> >>> `libqemustub.a'. Stop
> >
> >
- [Qemu-devel] [PULL 01/23] bios-linker-loader: document+validate input, (continued)
- [Qemu-devel] [PULL 01/23] bios-linker-loader: document+validate input, Michael S. Tsirkin, 2016/02/24
- [Qemu-devel] [PULL 03/23] move get_current_ram_size to virtio-balloon.c, Michael S. Tsirkin, 2016/02/24
- [Qemu-devel] [PULL 04/23] pc-dimm: rename pc_dimm_built_list(), Michael S. Tsirkin, 2016/02/24
- [Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list(), Michael S. Tsirkin, 2016/02/24
- Re: [Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list(), Vladimir Sementsov-Ogievskiy, 2016/02/25
- Re: [Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list(), Michael S. Tsirkin, 2016/02/25
- Re: [Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list(), Vladimir Sementsov-Ogievskiy, 2016/02/25
- Re: [Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list(), Michael S. Tsirkin, 2016/02/25
- Re: [Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list(), Vladimir Sementsov-Ogievskiy, 2016/02/25
- Re: [Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list(), Paolo Bonzini, 2016/02/25
- Re: [Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list(),
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list(), Michael S. Tsirkin, 2016/02/25
- Re: [Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list(), Vladimir Sementsov-Ogievskiy, 2016/02/26
- Re: [Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list(), Vladimir Sementsov-Ogievskiy, 2016/02/26
[Qemu-devel] [PULL 06/23] virtio-balloon: rewrite get_current_ram_size(), Michael S. Tsirkin, 2016/02/24
[Qemu-devel] [PULL 07/23] balloon: Use only 'pc-dimm' type dimm for ballooning, Michael S. Tsirkin, 2016/02/24
[Qemu-devel] [PULL 08/23] pci core: function pci_host_bus_register() cleanup, Michael S. Tsirkin, 2016/02/24
[Qemu-devel] [PULL 09/23] pci core: function pci_bus_init() cleanup, Michael S. Tsirkin, 2016/02/24
[Qemu-devel] [PULL 10/23] block-migration: acquire AioContext as necessary, Michael S. Tsirkin, 2016/02/24
[Qemu-devel] [PULL 11/23] vring: make vring_enable_notification return void, Michael S. Tsirkin, 2016/02/24
[Qemu-devel] [PULL 12/23] virtio: add AioContext-specific function for host notifiers, Michael S. Tsirkin, 2016/02/24