[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v3 05/21] balloon: Use only 'pc-dimm' type dimm for b
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL v3 05/21] balloon: Use only 'pc-dimm' type dimm for ballooning |
Date: |
Thu, 25 Feb 2016 13:20:34 +0200 |
From: Vladimir Sementsov-Ogievskiy <address@hidden>
For now there are only two dimm's: pc-dimm and nvdimm. This patch is
actually needed to disable ballooning on nvdimm. But, to avoid future
bugs, instead of disallowing nvdimm, we allow only pc-dimm. So, if
someone adds new dimm which should be balloon-able, then this ability
should be explicitly specified here.
Why ballooning for nvdimm should be disabled for now:
NVDIMM for now is planned to use as a backing store for DAX filesystem
in the guest and thus this memory is excluded from guest memory
management and LRUs.
In this case libvirt running QEMU along with configured balloon almost
immediately inflates balloon and effectively kill the guest as
qemu counts nvdimm as part of the ram.
Counting dimm devices as part of the ram for ballooning was started from
commit 463756d03:
virtio-balloon: Fix balloon not working correctly when hotplug memory
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/virtio/virtio-balloon.c | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index 388e873..e9c30e9 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -305,15 +305,33 @@ static void virtio_balloon_get_config(VirtIODevice *vdev,
uint8_t *config_data)
memcpy(config_data, &config, sizeof(struct virtio_balloon_config));
}
+static int build_dimm_list(Object *obj, void *opaque)
+{
+ GSList **list = opaque;
+
+ if (object_dynamic_cast(obj, TYPE_PC_DIMM)) {
+ DeviceState *dev = DEVICE(obj);
+ if (dev->realized) { /* only realized DIMMs matter */
+ *list = g_slist_prepend(*list, dev);
+ }
+ }
+
+ object_child_foreach(obj, build_dimm_list, opaque);
+ return 0;
+}
+
static ram_addr_t get_current_ram_size(void)
{
GSList *list = NULL, *item;
ram_addr_t size = ram_size;
- pc_dimm_build_list(qdev_get_machine(), &list);
+ build_dimm_list(qdev_get_machine(), &list);
for (item = list; item; item = g_slist_next(item)) {
Object *obj = OBJECT(item->data);
- size += object_property_get_int(obj, PC_DIMM_SIZE_PROP, &error_abort);
+ if (!strcmp(object_get_typename(obj), TYPE_PC_DIMM)) {
+ size += object_property_get_int(obj, PC_DIMM_SIZE_PROP,
+ &error_abort);
+ }
}
g_slist_free(list);
--
MST
- [Qemu-devel] [PULL v3 00/21] vhost, virtio, pci, pc, Michael S. Tsirkin, 2016/02/25
- [Qemu-devel] [PULL v3 02/21] vhost-user: don't merge regions with different fds, Michael S. Tsirkin, 2016/02/25
- [Qemu-devel] [PULL v3 03/21] move get_current_ram_size to virtio-balloon.c, Michael S. Tsirkin, 2016/02/25
- [Qemu-devel] [PULL v3 01/21] bios-linker-loader: document+validate input, Michael S. Tsirkin, 2016/02/25
- [Qemu-devel] [PULL v3 04/21] virtio-balloon: rewrite get_current_ram_size(), Michael S. Tsirkin, 2016/02/25
- [Qemu-devel] [PULL v3 05/21] balloon: Use only 'pc-dimm' type dimm for ballooning,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL v3 06/21] pci core: function pci_host_bus_register() cleanup, Michael S. Tsirkin, 2016/02/25
- [Qemu-devel] [PULL v3 07/21] pci core: function pci_bus_init() cleanup, Michael S. Tsirkin, 2016/02/25
- [Qemu-devel] [PULL v3 10/21] virtio: add AioContext-specific function for host notifiers, Michael S. Tsirkin, 2016/02/25
- [Qemu-devel] [PULL v3 11/21] virtio: export vring_notify as virtio_should_notify, Michael S. Tsirkin, 2016/02/25
- [Qemu-devel] [PULL v3 09/21] vring: make vring_enable_notification return void, Michael S. Tsirkin, 2016/02/25
- [Qemu-devel] [PULL v3 08/21] block-migration: acquire AioContext as necessary, Michael S. Tsirkin, 2016/02/25
- [Qemu-devel] [PULL v3 12/21] virtio-blk: fix "disabled data plane" mode, Michael S. Tsirkin, 2016/02/25
- [Qemu-devel] [PULL v3 14/21] virtio-scsi: do not use vring in dataplane, Michael S. Tsirkin, 2016/02/25
- [Qemu-devel] [PULL v3 13/21] virtio-blk: do not use vring in dataplane, Michael S. Tsirkin, 2016/02/25
- [Qemu-devel] [PULL v3 15/21] vring: remove, Michael S. Tsirkin, 2016/02/25