qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC 01/11] config/config-arm-common: build-up tests-co


From: Alex Bennée
Subject: Re: [Qemu-devel] [RFC 01/11] config/config-arm-common: build-up tests-common target
Date: Fri, 26 Feb 2016 14:16:43 +0000
User-agent: mu4e 0.9.17; emacs 25.0.91.1

Andrew Jones <address@hidden> writes:

> On Fri, Feb 26, 2016 at 01:15:23PM +0000, Alex Bennée wrote:
>> This is a source of needless conflicts when adding new tests and
>> re-basing. Let's just build up the lists of tests by hand.
>>
>> Signed-off-by: Alex Bennée <address@hidden>
>> ---
>>  config/config-arm-common.mak | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/config/config-arm-common.mak b/config/config-arm-common.mak
>> index 698555d..e037507 100644
>> --- a/config/config-arm-common.mak
>> +++ b/config/config-arm-common.mak
>> @@ -9,9 +9,8 @@ ifeq ($(LOADADDR),)
>>      LOADADDR = 0x40000000
>>  endif
>>
>> -tests-common = \
>> -    $(TEST_DIR)/selftest.flat \
>> -    $(TEST_DIR)/spinlock-test.flat
>> +tests-common = $(TEST_DIR)/selftest.flat
>> +tests-common += $(TEST_DIR)/spinlock-test.flat
>>
>>  all: test_cases
>>
>> --
>> 2.7.1
>>
>>
>
> I agree with this patch, but we could probably just squash it
> with the addition of the next test.

It was originally but during yet-another-rebase I thought I'd just
separate the patch so it wasn't dependant on what was merged next!

>
> drew


--
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]