[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v3 11/15] block: Assert that bdrv_r
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH v3 11/15] block: Assert that bdrv_release_dirty_bitmap succeeded |
Date: |
Mon, 29 Feb 2016 18:05:38 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 02/27/2016 04:20 AM, Fam Zheng wrote:
> We use a loop over bs->dirty_bitmaps to make sure the caller is
> only releasing a bitmap owned by bs. Let's also assert that in this case
> the caller is releasing a bitmap that does exist.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/dirty-bitmap.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
> index a0c5acb..27d33e7 100644
> --- a/block/dirty-bitmap.c
> +++ b/block/dirty-bitmap.c
> @@ -304,6 +304,9 @@ static void
> bdrv_do_release_matching_dirty_bitmap(BlockDriverState *bs,
> }
> }
> }
> + if (bitmap) {
> + abort();
> + }
> }
>
> void bdrv_release_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap *bitmap)
>
Bad context, but I assume what happens is if we have a bitmap, we have
an early return above, so this should be unreachable.
Reviewed-by: John Snow <address@hidden>
- [Qemu-devel] [PATCH v3 05/15] block: Remove unused typedef of BlockDriverDirtyHandler, (continued)
- [Qemu-devel] [PATCH v3 05/15] block: Remove unused typedef of BlockDriverDirtyHandler, Fam Zheng, 2016/02/27
- [Qemu-devel] [PATCH v3 04/15] block: Move block dirty bitmap code to separate files, Fam Zheng, 2016/02/27
- [Qemu-devel] [PATCH v3 06/15] block: Hide HBitmap in block dirty bitmap interface, Fam Zheng, 2016/02/27
- [Qemu-devel] [PATCH v3 07/15] HBitmap: Introduce "meta" bitmap to track bit changes, Fam Zheng, 2016/02/27
- [Qemu-devel] [PATCH v3 08/15] tests: Add test code for meta bitmap, Fam Zheng, 2016/02/27
- [Qemu-devel] [PATCH v3 09/15] block: Support meta dirty bitmap, Fam Zheng, 2016/02/27
- [Qemu-devel] [PATCH v3 10/15] block: Add two dirty bitmap getters, Fam Zheng, 2016/02/27
- [Qemu-devel] [PATCH v3 11/15] block: Assert that bdrv_release_dirty_bitmap succeeded, Fam Zheng, 2016/02/27
- Re: [Qemu-devel] [Qemu-block] [PATCH v3 11/15] block: Assert that bdrv_release_dirty_bitmap succeeded,
John Snow <=
- [Qemu-devel] [PATCH v3 12/15] hbitmap: serialization, Fam Zheng, 2016/02/27
- [Qemu-devel] [PATCH v3 13/15] block: BdrvDirtyBitmap serialization interface, Fam Zheng, 2016/02/27
- [Qemu-devel] [PATCH v3 14/15] tests: Add test code for hbitmap serialization, Fam Zheng, 2016/02/27
- [Qemu-devel] [PATCH v3 15/15] block: More operations for meta dirty bitmap, Fam Zheng, 2016/02/27