Re: [Qemu-devel] [PATCH] correct comment of MemoryHotplugState

[Igor Mammedov]

On Thu, 3 Mar 2016 17:24:12 +0800
Cao jin <address@hidden> wrote:

> correct comment and remove an unused macro. commit adcb4ee6 already
> correct its type
> 
> Signed-off-by: Cao jin <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>


> ---
> Btw, in pc_memory_init(), I don`t see in which condition, the following code
> will be executed:
> 
>     if ((pcms->hotplug_memory.base + hotplug_mem_size) <
>         hotplug_mem_size) {
>         error_report("unsupported amount of maximum memory: " RAM_ADDR_FMT,
>                       machine->maxram_size);
>         exit(EXIT_FAILURE);
>     }
> 
> I appreciate if anyone could give a hint
Integer overflow?

> 
> And PS: the output of *get_maintainer.pl this_patch* isn`t the same as
> *get_maintainer.pl -f include/hw/mem/pc-dimm.h*.
> I am not sure if it is a problem.
> 
>  include/hw/mem/pc-dimm.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
> index 218dfb0..8cdc326 100644
> --- a/include/hw/mem/pc-dimm.h
> +++ b/include/hw/mem/pc-dimm.h
> @@ -20,8 +20,6 @@
>  #include "sysemu/hostmem.h"
>  #include "hw/qdev.h"
>  
> -#define DEFAULT_PC_DIMMSIZE (1024*1024*1024)
> -
>  #define TYPE_PC_DIMM "pc-dimm"
>  #define PC_DIMM(obj) \
>      OBJECT_CHECK(PCDIMMDevice, (obj), TYPE_PC_DIMM)
> @@ -72,7 +70,7 @@ typedef struct PCDIMMDeviceClass {
>  
>  /**
>   * MemoryHotplugState:
> - * @base: address in guest RAM address space where hotplug memory
> + * @base: address in guest physical address space where hotplug memory
>   * address space begins.
>   * @mr: hotplug memory address space container
>   */