Re: [Qemu-devel] [PATCH] correct comment of MemoryHotplugState

[Cao jin]

On 03/03/2016 09:59 PM, Igor Mammedov wrote:
> On Thu, 3 Mar 2016 17:24:12 +0800
> Cao jin <address@hidden> wrote:
>
> > correct comment and remove an unused macro. commit adcb4ee6 already
> > correct its type
> >
> > Signed-off-by: Cao jin <address@hidden>
> Reviewed-by: Igor Mammedov <address@hidden>
>
>
> > ---
> > Btw, in pc_memory_init(), I don`t see in which condition, the following code
> > will be executed:
> >
> >      if ((pcms->hotplug_memory.base + hotplug_mem_size) <
> >          hotplug_mem_size) {
> >          error_report("unsupported amount of maximum memory: " RAM_ADDR_FMT,
> >                        machine->maxram_size);
> >          exit(EXIT_FAILURE);
> >      }
> >
> > I appreciate if anyone could give a hint
> Integer overflow?

Ah yes, make sense. Thanks very much for the hint

--
Yours Sincerely,

Cao jin