[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 2/5] nvdimm acpi: introduce patched dsm memor

From: Xiao Guangrong
Subject: Re: [Qemu-devel] [PATCH v5 2/5] nvdimm acpi: introduce patched dsm memory
Date: Fri, 4 Mar 2016 23:32:36 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

On 03/03/2016 09:12 PM, Michael S. Tsirkin wrote:

      /* copy AML table into ACPI tables blob and patch header there */
      g_array_append_vals(table_data, ssdt->buf->data, ssdt->buf->len);
+    mem_addr_offset = build_append_named_dword(table_data,
+                                               NVDIMM_ACPI_MEM_ADDR);
+    bios_linker_loader_alloc(linker, NVDIMM_DSM_MEM_FILE, TARGET_PAGE_SIZE,
+                             false /* high memory */);
+    bios_linker_loader_add_pointer(linker, ACPI_BUILD_TABLE_FILE,
+                                   NVDIMM_DSM_MEM_FILE, table_data,
+                                   table_data->data + mem_addr_offset,
+                                   sizeof(uint32_t));
      build_header(linker, table_data,
-        (void *)(table_data->data + table_data->len - ssdt->buf->len),
-        "SSDT", ssdt->buf->len, 1, NULL, "NVDIMM");
+        (void *)(table_data->data + nvdimm_ssdt),
+        "SSDT", table_data->len - nvdimm_ssdt, 1, NULL, "NVDIMM");

I prefer ssdt->buf->len to table_data->len - nvdimm_ssdt.
Pls fix by a follow-up patch unless there is a respin.

Ah, we can not do that as the NVDIMM_ACPI_MEM_ADDR is appended in the table
which is not taken into account in ssdt.

Sorry, i just spotted it when i was addressing all your comments in the new
version. :(

reply via email to

[Prev in Thread] Current Thread [Next in Thread]