[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 2/3] quorum: implement bdrv_add_child() and
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v10 2/3] quorum: implement bdrv_add_child() and bdrv_del_child() |
|
Date: |
Mon, 7 Mar 2016 09:02:07 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/05/2016 11:13 AM, Max Reitz wrote:
>> + index = atoi(child->name + 9);
>
> Optional: Assert absence of an error:
>
Indeed, atoi() is worthless, because it cannot do error detection.
> unsigned long index;
> char *endptr;
>
> index = strtoul(child->name + 9, &endptr, 10);
> assert(index >= 0 && !*endptr);
Still incorrect; you aren't handling errno properly for detecting all
errors. Even better is to use qemu_strtoul(), which already handles
proper error detection.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature