[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/2] Fix flaw of qemu_put_compression_data
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/2] Fix flaw of qemu_put_compression_data |
Date: |
Wed, 9 Mar 2016 16:31:25 +0530 |
On (Wed) 09 Mar 2016 [08:41:41], Li, Liang Z wrote:
>
> > -----Original Message-----
> > From: Li, Liang Z
> > Sent: Thursday, February 25, 2016 11:50 AM
> > To: address@hidden; address@hidden
> > Cc: address@hidden; address@hidden;
> > address@hidden; Li, Liang Z
> > Subject: [PATCH v3 0/2] Fix flaw of qemu_put_compression_data
> >
> > The implementation of qemu_put_compression_data only consider the case
> > QEMUFile is writable, it can't work with a writable QEMUFile and does not
> > provide any measure to prevent users from using it with a writable QEMUFile.
> > For safety, it should be improved to avoid some issues.
> >
> > ram_save_compressed_page can be refined based on the change of
> > qemu_put_compression_data, very small improvement, but code looks
> > better.
> >
> > Liang Li (2):
> > qemu-file: Fix qemu_put_compression_data flaw
> > migration: refine ram_save_compressed_page
> >
> > migration/qemu-file.c | 23 +++++++++++++++++++++--
> > migration/ram.c | 34 ++++++++++++++++++----------------
> > 2 files changed, 39 insertions(+), 18 deletions(-)
>
> Hi Juan & Amit,
>
> How about this patch set?
I know Juan had some reservations. Don't know if all his concerns
were addressed. I'll let him decide on this one.
Amit