Re: [Qemu-devel] [PATCH v1 18/21] osdep: remove use of Win32 specific closesocket/ioctlsocket

[Daniel P. Berrange]

On Wed, Mar 09, 2016 at 05:28:21PM +0000, Daniel P. Berrange wrote:
> Now that QEMU replaces the close() and ioctl() methods with
> a wrapper that can transparently handle both sockets and
> regular file handles on Win32, there is no need to ever
> use the closesocket/ioctlsocket methods. The code can simply
> use the normal POSIX methods.
> 
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  block/sheepdog.c           | 36 ++++++++++++++++++------------------
>  include/qemu/sockets.h     |  4 ----
>  io/channel-socket.c        |  2 +-
>  migration/qemu-file-unix.c |  2 +-
>  migration/tcp.c            |  4 ++--
>  net/socket.c               | 20 ++++++++++----------
>  slirp/ip_icmp.c            |  2 +-
>  slirp/misc.c               |  4 ++--
>  slirp/slirp.h              |  2 --
>  slirp/socket.c             |  2 +-
>  slirp/tcp_subr.c           |  6 +++---
>  slirp/udp.c                |  2 +-
>  util/qemu-sockets.c        | 12 ++++++------
>  13 files changed, 46 insertions(+), 52 deletions(-)

Given feedback from Paolo on the previous patch, I'm dropping this
patch.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|