[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] usb: fix unbounded stack warning for xhci_dma_w
Re: [Qemu-devel] [PATCH] usb: fix unbounded stack warning for xhci_dma_write_u32s
Fri, 11 Mar 2016 09:44:52 +0800
On Thu, Mar 10, 2016 at 10:21:45AM +0100, Gerd Hoffmann wrote:
> On Do, 2016-03-10 at 15:56 +0800, Peter Xu wrote:
> > As mentioned in previous thread, because all the callers of
> > xhci_dma_write_u32s() are using const size in "len". The maximum
> > currently is 5 * sizeof(uint32_t) = 20 bytes
> Can you note that in the commit message please?
> > . Here I choose number
> > bigger than 5 should work for now.
> Why bigger? 5 should do just fine then, and the assert added should
> make sure we'll notice if this needs an update due to code changes
Will repost with 5.