[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 18/26] tests: add output filter to python I/O
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v4 18/26] tests: add output filter to python I/O tests helper |
Date: |
Mon, 14 Mar 2016 18:33:03 +0000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Mar 14, 2016 at 11:57:11AM -0600, Eric Blake wrote:
> On 02/29/2016 05:00 AM, Daniel P. Berrange wrote:
> > Add a 'log' method to iotests.py which prints messages to
> > stdout, with optional filtering of data. Port over some
> > standard filters for present in the shell common.filter
> > code.
>
> I'm not sure what you meant by 'for present'.
Nor am I :-)
Perhaps I meant to say 'already present'
> >
> > Signed-off-by: Daniel P. Berrange <address@hidden>
> > ---
> > tests/qemu-iotests/iotests.py | 25 ++++++++++++++++++++++++-
> > 1 file changed, 24 insertions(+), 1 deletion(-)
> >
>
> But the patch itself looks reasonable.
> Reviewed-by: Eric Blake <address@hidden>
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|