Re: [Qemu-devel] [PATCH v2] Sort the fw_cfg file list

[Gerd Hoffmann]

  Hi,

> So here is what I propose instead:
> 
> - always initialize it late
> - sort late, a machine done, not when inserting entries
> - figure out what the order of existing entries is currently,
>   and fill an array listing them in this order.
>   for old machine types, insert the existing entries
>   in this specific order by using a sorting function:

What is the point of using *two* ways to sort entries?

Sure, we can explicitly write down the current order of fw_cfg entries
and use that to sort them, so order stays as-is even if the
initialization order changes.  But when going that route I would do that
*instead* of the alphabetical ordering, for all machine types.

cheers,
  Gerd