qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without o


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/
Date: Thu, 17 Mar 2016 11:22:46 +0100

  Hi,

> Occasionally, yes.
> 
> - "opt/ovmf/PcdPropertiesTableEnable" controls whether the "properties

> - "opt/ovmf/PcdSetNxForStack" controls whether the stack is made

> - "opt/ovmf/X-PciMmio64Mb" controls the size of the range from which the

> In downstream, we have two more (same purpose but separately for ARM and
> x86):
> - opt/aavmf/PcdResizeXterm
> - opt/ovmf/PcdResizeXterm
> 
> - Another flag I might expose later is "PcdHiiOsRuntimeSupport". This

I think we should probably move those out of the opt/ namespace space,
as this is reserved for user-defined files.

I think either "etc/efi/" or "efi/" is useful (so we don't have
different names on ovmf and aavmf).  Possibly add "pcd/".  Maybe even
support setting *any* pcd via "efi/pcd/$name" (just an idea, not sure
whenever that is useful and is possible without being too invasive).

> - "opt/ovmf/X-PciMmio64Mb" controls the size of the range from which 

Hmm.  Leave as-is for now I'd say.  If we decide to keep it we should
probably rename it and place it below etc/, next to reserved-memory-end.
Export the size in bytes, like reserved-memory-end does.  Add an option
to qemu to set it, so you can specify the size as "32G" using the
standard qemu size parser.

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]