[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] tcg: always keep jump target and tb->jmp_ne
Re: [Qemu-devel] [PATCH 3/5] tcg: always keep jump target and tb->jmp_next consistent
Thu, 17 Mar 2016 20:31:22 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0
On 17/03/2016 18:57, Richard Henderson wrote:
> > @@ -951,18 +959,10 @@ static inline void tb_jmp_remove(TranslationBlock
> > *tb, int n)
> > }
> > /* now we can suppress tb(n) from the list */
> > *ptb = tb->jmp_next[n];
> > -
> > - tb->jmp_next[n] = NULL;
> > + tb_reset_jump(tb, n);
> What's the motivation here? This implies an extra cache flush.
> Where were we resetting the jump previously? Or is this a bug
> in that we *weren't* resetting the jump previously?
Indeed I think this patch can be removed if it has a performance effect
on machines that require icache invalidation. If it doesn't, it would
be just a small code simplification.
[Qemu-devel] [PATCH 5/5] tcg: move tb_invalidated_flag to CPUState, sergey . fedorov, 2016/03/17
[Qemu-devel] [PATCH 2/5] tcg: reorganize tb_find_physical loop, sergey . fedorov, 2016/03/17