[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH qemu] vmstate: Define VARRAY with VMS_ALLOC

From: Alexey Kardashevskiy
Subject: Re: [Qemu-devel] [PATCH qemu] vmstate: Define VARRAY with VMS_ALLOC
Date: Mon, 21 Mar 2016 17:25:04 +1100
User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0

On 03/15/2016 02:17 PM, Alexey Kardashevskiy wrote:
This allows dynamic allocation for migrating arrays.

Already existing VMSTATE_VARRAY_UINT32 requires an array to be
pre-allocated, however there are cases when the size is not known in
advance and there is no real need to enforce it.

This defines another variant of VMSTATE_VARRAY_UINT32 with WMS_ALLOC
flag which tells the receiving side to allocate memory for the array
before receiving the data.

The first user of it is the "pseries" machine (POWER8) with
dynamic DMA windows which existence and size are totally dynamic.

Signed-off-by: Alexey Kardashevskiy <address@hidden>
Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>

As David suggested, I am posting it alone (separately from the DDW patchset).

It would be nice either to get "ack" to get this pulled via the powerpc
tree or get it pulled to the upstream via some other tree. Thanks!

So what is about this patch? Ack, nack? Thanks!

  include/migration/vmstate.h | 10 ++++++++++
  1 file changed, 10 insertions(+)

diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 84ee355..1622638 100644
--- a/include/migration/vmstate.h
+++ b/include/migration/vmstate.h
@@ -386,6 +386,16 @@ extern const VMStateInfo vmstate_info_bitmap;
      .offset     = vmstate_offset_pointer(_state, _field, _type),     \

+#define VMSTATE_VARRAY_UINT32_ALLOC(_field, _state, _field_num, _version, 
_info, _type) {\
+    .name       = (stringify(_field)),                               \
+    .version_id = (_version),                                        \
+    .num_offset = vmstate_offset_value(_state, _field_num, uint32_t),\
+    .info       = &(_info),                                          \
+    .size       = sizeof(_type),                                     \
+    .flags      = VMS_VARRAY_UINT32|VMS_POINTER|VMS_ALLOC,           \
+    .offset     = vmstate_offset_pointer(_state, _field, _type),     \
  #define VMSTATE_VARRAY_UINT16_UNSAFE(_field, _state, _field_num, _version, 
_info, _type) {\
      .name       = (stringify(_field)),                               \
      .version_id = (_version),                                        \


reply via email to

[Prev in Thread] Current Thread [Next in Thread]