[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] qdict: fix unbounded stack warning for qdict

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v2] qdict: fix unbounded stack warning for qdict_array_entries
Date: Tue, 22 Mar 2016 16:39:36 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Peter Xu <address@hidden> writes:

> Here we use one g_strdup_printf() to replace the two stack allocated
> array, considering it's more convenient, safe, and as long as it's
> called rarely only when quorum device opens. This will remove the
> unbound stack warning when compiling with "-Wstack-usage=1000000".
> Reviewed-by:   Eric Blake <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>

Reviewed-by: Markus Armbruster <address@hidden>

I lack the time to take this through my tree before my Easter vacation.
Nominating for qemu-trivial, assuming Luiz doesn't mind.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]