[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 0/4] Implement some QKeyCode support

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v5 0/4] Implement some QKeyCode support
Date: Wed, 23 Mar 2016 17:47:57 +0000

On 23 March 2016 at 16:52, Programmingkid <address@hidden> wrote:
> On Mar 23, 2016, at 10:37 AM, Peter Maydell wrote:
>> I've put the qapi-schema.json and the ui/cocoa.m patches into the
>> cocoa pull I've just sent. For the ADB keyboard part, I definitely
>> think that the best approach is the suggestion I made on an earlier
>> series: split the changes up into "move to using QKeyCode and the
>> adb-keys.h enum values, but don't change any behaviour of what keys
>> get sent", and "fix bugs, add missing keys, etc" as separate changes.
>> This will be much easier to review.
> Would it be ok to send the adb-keys.h and adb.c patches separately
> instead of using a series? It would make things a lot easier for me.

Please sort out a config that lets you send patch series properly --
it is a real pain to deal with them at my end otherwise.

> You want the adb.c patch so that it does not have the keypad equals
> and power keys in it yet? You want those keys added in a separate
> patch?

You want three (or more) patches, I guess:
 * new adb-keys.h file
 * changes to adb.c which make no guest-visible changes to behaviour
 * patches which change behaviour, split up to do one thing at a time
   [probably at least "support power key", "don't send 'A' for unknown
   keycodes", and "other changes"]

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]