[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] util: move declarations out of qemu-common.h

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] util: move declarations out of qemu-common.h
Date: Wed, 23 Mar 2016 18:17:09 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0

On 03/20/2016 08:43 AM, Veronia wrote:
> move declarations out of qemu-common.h for functions declared in
> utils/ files: e.g. include/qemu/path.h for utils/path.c.
> move inline functions out of qemu-common.h and into new files (e.g.
> include/qemu/bcd.h)
> Signed-off-by: Veronia Bahaa<address@hidden@gmail.com>

Space before <.  'git commit -s' (or 'git commit --amend -s' on an
existing commit) will space things correctly if your ~/.gitconfig is
correct; if you are typing the S-o-b by hand, I recommend figuring out
how to get git to do it for you.

> ---

>  161 files changed, 439 insertions(+), 320 deletions(-)
>  create mode 100644 include/qemu/bcd.h
>  create mode 100644 include/qemu/cutils.h
>  create mode 100644 include/qemu/help_option.h
>  create mode 100644 include/qemu/id.h
>  create mode 100644 include/qemu/path.h
>  create mode 100644 include/qemu/unicode.h

This is a big patch.  To make review easier, I highly suggest that you
repost this as a series of (at least) 6 patches, one per file (if any
one include file is huge, it might help to further break it down into
2-3 related functions per patch rather than all functions belonging to
the file).

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]