[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] Add gpio_key and use it for ARM virt power
Re: [Qemu-devel] [PATCH 0/2] Add gpio_key and use it for ARM virt power button
Thu, 24 Mar 2016 08:58:20 +0800
Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
On 2016/3/24 1:14, Wei Huang wrote:
> On 03/23/2016 11:12 AM, Peter Maydell wrote:
>> > On 17 March 2016 at 13:25, Shannon Zhao <address@hidden> wrote:
>>> >> From: Shannon Zhao <address@hidden>
>>> >> There is a problem for power button that it will not work if an early
>>> >> system_powerdown request happens before guest gpio driver loads.
>>> >> Here we add the emulation of gpio_key and use it for ARM virt power
>>> >> button.
>> > I tweaked the type names to be 'gpio-key' rather than 'gpio_key',
>> > and added a comment to briefly describe what the device does:
>> > + * Emulate a (human) keypress -- when the key is triggered by
>> > + * setting the incoming gpio line, the outbound irq line is
>> > + * raised for 100ms before being dropped again.
Great. Thanks a lot!
>> > Applied to target-arm.next, thanks.
> I didn't see the patch series until yesterday. So just to make it
> complete, I did test it with both DT and ACPI modes. The patch seemed to
> work as intended.
> Tested-by: Wei Huang <address@hidden>