[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] util: Improved qemu_hexmap() to include an a

From: Thomas Huth
Subject: Re: [Qemu-devel] [PATCH v2] util: Improved qemu_hexmap() to include an ascii dump of the buffer
Date: Wed, 30 Mar 2016 09:18:40 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0

There's a typo in the title: qemu_hexmap should be qemu_hexdump/ instead.

On 25.03.2016 11:42, Isaac Lozano wrote:
> qemu_hexdump() in util/hexdump.c has been changed to give also include a
> ascii dump of the buffer. Also, calls to hex_dump() in net/net.c have
> been replaced with calls to qemu_hexdump(). This takes care of two misc
> BiteSized Tasks.
> Signed-off-by: Isaac Lozano <address@hidden>
> ---
> v2: Fixed code-style and made debug line smaller.
>  net/net.c      | 30 +-----------------------------
>  util/hexdump.c | 33 ++++++++++++++++++++++-----------
>  2 files changed, 23 insertions(+), 40 deletions(-)

Code looks fine now, thanks for taking care of this!

Reviewed-by: Thomas Huth <address@hidden>

Jason, since there is no explicit maintainer for util/hexdump.c, could
you maybe take this through your net tree, since this patch touches
net/net.c as well?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]