[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v1] util: don't use AI_V4MAPPED flag to getaddrinfo

From: Daniel P. Berrange
Subject: [Qemu-devel] [PATCH v1] util: don't use AI_V4MAPPED flag to getaddrinfo on FreeBSD
Date: Thu, 31 Mar 2016 14:06:50 +0100

The FreeBSD header files define the AI_V4MAPPED but its
implementation of getaddrinfo() always returns an error
when that flag is set. eg

  address resolution failed for localhost:9000: Invalid value for ai_flags

Since this flag is not critical for DNS lookups, just
undefine it on FreeBSD platforms.

Signed-off-by: Daniel P. Berrange <address@hidden>
 util/qemu-sockets.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index b87e17f..3007345 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -29,6 +29,15 @@
 # define AI_ADDRCONFIG 0
+/* FreeBSD defines AI_V4MAPPED in its header files but its
+ * getaddrinfo() implementation always returns an error
+ * when it is used. Tested with FreeBSD 10.2. Recheck new
+ * releases periodically to see if this gets fixed....
+ */
+#if defined(AI_V4MAPPED) && defined(__FreeBSD__)
+# undef AI_V4MAPPED
 #ifndef AI_V4MAPPED
 # define AI_V4MAPPED 0

reply via email to

[Prev in Thread] Current Thread [Next in Thread]