[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tcg/mips: Fix type of tcg_target_reg_alloc_orde
Re: [Qemu-devel] [PATCH] tcg/mips: Fix type of tcg_target_reg_alloc_order
Fri, 1 Apr 2016 13:44:57 -0700
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1
On 04/01/2016 07:49 AM, James Hogan wrote:
The MIPS TCG backend is the only one to have
tcg_target_reg_alloc_order elements of type TCGReg rather than int.
This resulted in commit 91478cefaaf2 ("tcg: Allocate indirect_base
temporaries in a different order") breaking the build on MIPS since the
type differed from indirect_reg_alloc_order:
tcg/tcg.c:1725:44: error: pointer type mismatch in conditional expression
order = rev ? indirect_reg_alloc_order : tcg_target_reg_alloc_order;
Make it an array of ints to fix the build and match other architectures.
Fixes: 91478cefaaf2 ("tcg: Allocate indirect_base temporaries in a different
Signed-off-by: James Hogan<address@hidden>
Cc: Aurelien Jarno<address@hidden>
Cc: Richard Henderson<address@hidden>
tcg/mips/tcg-target.inc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <address@hidden>
Sorry, I've had the same fix queued for some time, but have
failed to include it in a tcg pull. I'll rectify that soon.