Re: [Qemu-devel] [PATCH] tcg/mips: Fix type of tcg_target_reg_alloc_order[]

[Richard Henderson]

On 04/01/2016 07:49 AM, James Hogan wrote:
> The MIPS TCG backend is the only one to have
> tcg_target_reg_alloc_order[] elements of type TCGReg rather than int.
> This resulted in commit 91478cefaaf2 ("tcg: Allocate indirect_base
> temporaries in a different order") breaking the build on MIPS since the
> type differed from indirect_reg_alloc_order[]:
>
> tcg/tcg.c:1725:44: error: pointer type mismatch in conditional expression 
> [-Werror]
>       order = rev ? indirect_reg_alloc_order : tcg_target_reg_alloc_order;
>                                              ^
>
> Make it an array of ints to fix the build and match other architectures.
>
> Fixes: 91478cefaaf2 ("tcg: Allocate indirect_base temporaries in a different 
> order")
> Signed-off-by: James Hogan<address@hidden>
> Cc: Aurelien Jarno<address@hidden>
> Cc: Richard Henderson<address@hidden>
> ---
>   tcg/mips/tcg-target.inc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <address@hidden>

Sorry, I've had the same fix queued for some time, but have
failed to include it in a tcg pull.  I'll rectify that soon.


r~