qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] block: forbid x-blockdev-del from acting on Dri


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH] block: forbid x-blockdev-del from acting on DriveInfo
Date: Mon, 4 Apr 2016 12:53:11 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 31.03.2016 um 15:07 hat Paolo Bonzini geschrieben:
> Failing on -drive/drive_add created BlockBackends was a
> requirement for x-blockdev-del, but it sneaked through
> the patch review.  Let's fix it now.
> 
> Example:
> 
> $ x86_64-softmmu/qemu-system-x86_64 -drive if=none,file=null-co://,id=null 
> -qmp stdio
> >> {'execute':'qmp_capabilities'}
> << {"return": {}}
> >> {'execute':'x-blockdev-del','arguments':{'id':'null'}}
> << {"error": {"class": "GenericError", "desc": "Deleting block backend added 
> with drive-add is not supported"}}
> 
> And without a DriveInfo:
> 
> >> { "execute": "blockdev-add", "arguments": { "options": { 
> >> "driver":"null-co", "id":"null2"}}}
> << {"return": {}}
> >> {'execute':'x-blockdev-del','arguments':{'id':'null2'}}
> << {"return": {}}
> 
> Suggested-by: Kevin Wolf <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>

Thanks, applied to the block branch.

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]