[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 13/13] net: Introduce e1000e device emulation

From: Dmitry Fleytman
Subject: Re: [Qemu-devel] [PATCH v2 13/13] net: Introduce e1000e device emulation
Date: Wed, 6 Apr 2016 16:42:57 +0300

> On 6 Apr 2016, at 16:23 PM, Michael S. Tsirkin <address@hidden> wrote:
> On Wed, Apr 06, 2016 at 11:22:24AM +0300, Dmitry Fleytman wrote:
>>        +    MemoryRegion flash;
>>    Looks there's no real implementation for flash. So is this really needed
>>    (e.g did WHQL or other test check for this?).
>> From our experience some drivers may verify that device exposes all memory
>> regions as required by HW specification, so we added this dummy memory region
>> to be on the safe side.
> But then, why use an io region?

Do you mean we should use memory_region_init() instead of 
memory_region_init_io() for registration?

> Also, pls add some comments that explains this.

I’ll add. Thanks.

> -- 
> MSt

reply via email to

[Prev in Thread] Current Thread [Next in Thread]