[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.6] vpc: fix return value check for blk_pwr
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.6] vpc: fix return value check for blk_pwrite |
|
Date: |
Fri, 8 Apr 2016 13:55:07 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 07.04.2016 um 16:52 hat Paolo Bonzini geschrieben:
> bdrv_pwrite_sync used to return zero or negative error, while blk_pwrite
> returns
> the number of written bytes when successful. This caused VPC image creation
> to fail spectacularly: it wrote the first 512 bytes, and then exited
> immediately
> because of the non-zero answer from blk_pwrite. But the truly spectacular
> part
> is that it returns a positive value (the 512 that blk_pwrite returned) causing
> everyone to believe that it succeeded.
>
> This fixes qemu-iotests with vpc format.
>
> Fixes: b8f45cdf7827e39f9a1e6cc446f5972cc6144237
> Signed-off-by: Paolo Bonzini <address@hidden>
Thanks, applied to the block branch.
Kevin