qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/2] block: Fix hang with mirror


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/2] block: Fix hang with mirroring qcow2
Date: Fri, 8 Apr 2016 14:15:44 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0


On 08/04/2016 12:06, Stefan Hajnoczi wrote:
> On Tue, Apr 05, 2016 at 07:20:51PM +0800, Fam Zheng wrote:
>> See patch 1 for the bug analysis.
>>
>> v3: Make bdrv_co_drain a public function and use it directly in 
>> block/mirror.c.
>>     [Stefan]
>>
>>
>>
>> Fam Zheng (2):
>>   block: Fix bdrv_drain in coroutine
>>   mirror: Replace bdrv_drain(bs) with bdrv_co_drain(bs)
>>
>>  block/io.c            | 45 +++++++++++++++++++++++++++++++++++++++++++++
>>  block/mirror.c        |  2 +-
>>  include/block/block.h |  1 +
>>  3 files changed, 47 insertions(+), 1 deletion(-)
>>
>> -- 
>> 2.7.4
> 
> Thanks, applied to my block tree:
> https://github.com/stefanha/qemu/commits/block

FWIW, I've now rebased my bdrv_drain patches on top of this, and the
need for the extra bottom half is gone!  This is a much better solution
for that other problem with mirror.c.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]