[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 06/13] qemu-thread: add simple test-and-set s
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v2 06/13] qemu-thread: add simple test-and-set spinlock |
Date: |
Fri, 08 Apr 2016 14:02:11 +0100 |
User-agent: |
mu4e 0.9.17; emacs 25.0.92.5 |
Emilio G. Cota <address@hidden> writes:
> From: Guillaume Delbergue <address@hidden>
>
> Signed-off-by: Guillaume Delbergue <address@hidden>
> [Rewritten. - Paolo]
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> include/qemu/thread.h | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/include/qemu/thread.h b/include/qemu/thread.h
> index bdae6df..1aa843b 100644
> --- a/include/qemu/thread.h
> +++ b/include/qemu/thread.h
> @@ -1,6 +1,8 @@
> #ifndef __QEMU_THREAD_H
> #define __QEMU_THREAD_H 1
>
> +#include <errno.h>
> +#include "qemu/atomic.h"
>
> typedef struct QemuMutex QemuMutex;
> typedef struct QemuCond QemuCond;
> @@ -60,4 +62,33 @@ struct Notifier;
> void qemu_thread_atexit_add(struct Notifier *notifier);
> void qemu_thread_atexit_remove(struct Notifier *notifier);
>
> +typedef struct QemuSpin {
> + int value;
If we are throwing true and false around as the only two values can we
use bool here and be consistent when setting/clearing.
> +} QemuSpin;
> +
> +static inline void qemu_spin_init(QemuSpin *spin)
> +{
> + spin->value = 0;
> +}
> +
> +static inline void qemu_spin_lock(QemuSpin *spin)
> +{
> + do {
> + while (atomic_read(&spin->value));
> + } while (atomic_xchg(&spin->value, true));
> +}
> +
> +static inline int qemu_spin_trylock(QemuSpin *spin)
> +{
> + if (atomic_read(&spin->value) || atomic_xchg(&spin->value, true)) {
> + return -EBUSY;
> + }
> + return 0;
> +}
> +
> +static inline void qemu_spin_unlock(QemuSpin *spin)
> +{
> + atomic_mb_set(&spin->value, 0);
> +}
> +
> #endif
--
Alex Bennée
- [Qemu-devel] [PATCH v2 00/10] tb hash improvements, Emilio G. Cota, 2016/04/07
- [Qemu-devel] [PATCH v2 05/13] include/processor.h: define cpu_relax(), Emilio G. Cota, 2016/04/07
- [Qemu-devel] [PATCH v2 12/13] qht: add test program, Emilio G. Cota, 2016/04/07
- [Qemu-devel] [PATCH v2 09/13] exec: add tb_hash_func5, derived from xxhash, Emilio G. Cota, 2016/04/07
- [Qemu-devel] [PATCH v2 04/13] seqlock: rename write_lock/unlock to write_begin/end, Emilio G. Cota, 2016/04/07
- [Qemu-devel] [PATCH v2 06/13] qemu-thread: add simple test-and-set spinlock, Emilio G. Cota, 2016/04/07
- Re: [Qemu-devel] [PATCH v2 06/13] qemu-thread: add simple test-and-set spinlock,
Alex Bennée <=
- Re: [Qemu-devel] [PATCH v2 06/13] qemu-thread: add simple test-and-set spinlock, Richard Henderson, 2016/04/08
- Re: [Qemu-devel] [PATCH v2 06/13] qemu-thread: add simple test-and-set spinlock, Alex Bennée, 2016/04/08
- Re: [Qemu-devel] [PATCH v2 06/13] qemu-thread: add simple test-and-set spinlock, Paolo Bonzini, 2016/04/08
- Re: [Qemu-devel] [PATCH v2 06/13] qemu-thread: add simple test-and-set spinlock, Richard Henderson, 2016/04/08
- Re: [Qemu-devel] [PATCH v2 06/13] qemu-thread: add simple test-and-set spinlock, Sergey Fedorov, 2016/04/08
Re: [Qemu-devel] [PATCH v2 06/13] qemu-thread: add simple test-and-set spinlock, Richard Henderson, 2016/04/08
[Qemu-devel] [PATCH v2 10/13] tb hash: hash phys_pc, pc, and flags with xxhash, Emilio G. Cota, 2016/04/07
[Qemu-devel] [PATCH v2 02/13] compiler.h: add QEMU_ALIGNED() to enforce struct alignment, Emilio G. Cota, 2016/04/07