Re: [Qemu-devel] [PATCH 04/18] nbd: Detect servers that send unexpected error values

[Alex Bligh]

On 8 Apr 2016, at 23:05, Eric Blake <address@hidden> wrote:

> Add some debugging to flag servers that are not compliant to
> the NBD protocol.
> 
> Signed-off-by: Eric Blake <address@hidden>


Reviewed-by: Alex Bligh <address@hidden>

> ---
> nbd/client.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/nbd/client.c b/nbd/client.c
> index 42e4e52..c834587 100644
> --- a/nbd/client.c
> +++ b/nbd/client.c
> @@ -33,8 +33,10 @@ static int nbd_errno_to_system_errno(int err)
>         return ENOMEM;
>     case NBD_ENOSPC:
>         return ENOSPC;
> +    default:
> +        TRACE("Squashing unexpected error %d to EINVAL", err);
> +        /* fallthrough */
>     case NBD_EINVAL:
> -    default:
>         return EINVAL;
>     }
> }
> -- 
> 2.5.5
> 
> 

-- 
Alex Bligh