[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 5/5] Add param Error ** for msi_init()

From: Cao jin
Subject: Re: [Qemu-devel] [PATCH v4 5/5] Add param Error ** for msi_init()
Date: Mon, 11 Apr 2016 20:02:25 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 04/11/2016 06:00 PM, Marcel Apfelbaum wrote:

2). If user doesn`t order msi on(so device have msi on by default),
when msi_init returns -ENOTSUP, I am ok with Markus`s suggestion:
*caller should silently switch to the non-MSI variant*

But now the condition is, qemu can`t distinguish whether user ordered
msi or not, so for the condition 2) above, my suggestion is the same
as 1)

If we can't distinguish between the cases, 2 would not be user-friendly.
Once it would be possible to differentiate we could go for 2.


How to differentiate? Do you mean: let these msi(msix) property default to 'off'? It seem most device have it on, a few have it off.


Yours Sincerely,

Cao jin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]